Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx the affinity setting bug when using LCI pp and multiple localities per node #6400

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

JiakunYan
Copy link
Contributor

@JiakunYan JiakunYan commented Dec 14, 2023

Fixes #6398.

The HPX runtime relies on used_cores_map_ to set the affinity correctly when running multiple localities per node (see runtime_distributed::assign_cores for details). used_cores_map_ maps hostnames to "used cores" and assumes the hostname of all localities on the same node are the same. The hostname is generated using the parcelport::get_locality_name method (I would say the name of this method is misleading).

The previous LCI parcelport used "processor_name+rank" as a locality name, which breaks the assumption of used_cores_map_. This PR fixed this issue.

@StellarBot
Copy link

Can one of the admins verify this patch?

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.12% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1cf717d) 397874 336695 84.62%
Head commit (dd67224) 195085 (-202789) 164856 (-171839) 84.50% (-0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6400) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser
Copy link
Member

hkaiser commented Dec 15, 2023

add to whitelist

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Dec 15, 2023

bors merge

@hkaiser hkaiser merged commit 8b438bf into STEllAR-GROUP:master Dec 18, 2023
63 of 71 checks passed
@JiakunYan JiakunYan deleted the fix-6398 branch December 18, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPX sets affinity wrong with multiple processes per node and LCI parcelport enabled
3 participants