Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure HPX_WITH_ASYNC_MPI is reported properly #6429

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 31, 2024

Fixes #5921

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.14%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9c53b99) 206733 176197 85.23%
Head commit (941addc) 190772 (-15961) 162332 (-13865) 85.09% (-0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6429) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@John98Zakaria
Copy link
Contributor

Thanks for fixing the issue 🥳
I tested your branch and it worked on my machine

@hkaiser hkaiser merged commit 76bcb86 into master Feb 3, 2024
61 of 72 checks passed
@hkaiser hkaiser deleted the fixing_5921 branch February 3, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hpx::info claims that async_mpi was not built, while cmake assures its existence
2 participants