Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agas addressing cache #6445

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix agas addressing cache #6445

merged 1 commit into from
Feb 23, 2024

Conversation

JiakunYan
Copy link
Contributor

Fixes #6443

The get_entry method of lru_cache is not read-only. There is a touch method being invoked inside it.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.09% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd9e3cb) 206733 176202 85.23%
Head commit (a21ee01) 190747 (-15986) 162397 (-13805) 85.14% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6445) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser hkaiser merged commit 40eef48 into STEllAR-GROUP:master Feb 23, 2024
62 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #6435 (parcel_layer_tweaks) broke Octo-Tiger
2 participants