Standardising Benchmarks, with support for nanobench as an option for its backend #6448
+449
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
|
Congratulations for getting nanobench into the build system! |
Thanks for the response, but I am unable to see your suggestions in the PR. Could you please check once from your side? |
isidorostsa
reviewed
Mar 6, 2024
|
retest |
|
@vrnimje Thanks for making the changes for this to work. Unfortunately, our Jenkins CI is not working right now due to some issues on our side. I'll trigger the jobs once we've resolved the issue. Thanks for your patience. |
Ok, thanks for letting me know |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
|
retest lsu |
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
…x perf test Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
…minor changes to plotting script * Further simplified the default template for the benchmark Signed-off-by: Vedant <[email protected]>
…accordingly Signed-off-by: Vedant <[email protected]>
…orrect option Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
…, and made minor changes to perftests ci Signed-off-by: Vedant <[email protected]>
Signed-off-by: Vedant <[email protected]>
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Pansysk75
reviewed
Jul 13, 2024
tools/perftests_plot.py
Outdated
Comment on lines
1
to
31
| import sys | ||
| import subprocess | ||
| import json | ||
| import matplotlib.pyplot as plt | ||
|
|
||
| if len(sys.argv) != 2: | ||
| if len(sys.argv) == 1: | ||
| print("No benchmark selected!") | ||
| else: | ||
| print("Too many arguments!") | ||
| print("Usage: python perftests_plot.py [path_to_benchmark_binary]") | ||
| else: | ||
| test_name = sys.argv[1] | ||
|
|
||
| contents = subprocess.run([test_name, "--detailed_bench"], capture_output=True) | ||
|
|
||
| json_obj = json.loads(contents.stdout.decode('utf-8')) | ||
|
|
||
| test_names = [] | ||
| samples = [] | ||
|
|
||
| for test in json_obj["outputs"]: | ||
| test_names.append(test["name"] + ",\n" + test["executor"]) | ||
| samples.append(test["series"]) | ||
|
|
||
| fig = plt.figure(figsize=(20, 6)) | ||
| ax = fig.add_subplot() | ||
| bp = ax.boxplot(samples, showfliers=False) | ||
| plt.setp(ax.set_xticklabels(test_names), fontsize=7) | ||
| plt.show() | ||
|
|
Pansysk75
reviewed
Jul 13, 2024
CMakeLists.txt
Outdated
| hpx_option( | ||
| HPX_WITH_NANOBENCH | ||
| BOOL | ||
| "Use Nanobench for performance tests. Nanobench will be fetched using FetchContent (defualt: OFF)" |
Pansysk75
reviewed
Jul 13, 2024
Comment on lines
37
to
41
| // std::cout << "-----Average-(hpx::small_vector<" << typeid(T).name() << ", " | ||
| // << N << ">)------ \n" | ||
| // << std::left << "Average execution time : " << std::right | ||
| // << std::setw(8) << time / 1e9 << "\n"; | ||
| // } |
Signed-off-by: Vedant <[email protected]>
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background context: #6357
Proposed Changes
perftests_report, which also supports nanobench as the backend