Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distance.cpp test in CMake #6471

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Add distance.cpp test in CMake #6471

merged 2 commits into from
Jul 13, 2024

Conversation

gonidelis
Copy link
Contributor

Neglected to add the unit test when I wrote it, so I just add it now :)

@hkaiser
Copy link
Member

hkaiser commented Apr 10, 2024

@gonidelis could you please have a look at the configuration errors?

@hkaiser hkaiser modified the milestones: 1.10.0, 1.11.0 May 3, 2024
@gonidelis
Copy link
Contributor Author

gonidelis commented Jul 4, 2024

@hkaiser fixed. sorry about that.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-85.09%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3add538) 216439 184172 85.09%
Head commit (7f8df5d) 51316 (-165123) 0 (-184172) 0.00% (-85.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6471) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 4add796 into master Jul 13, 2024
49 of 80 checks passed
@hkaiser hkaiser deleted the distance_test branch July 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants