-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test cases and fixes for the S/R versions of the parallel algorithms #6494
Commits on May 22, 2024
-
Add more unit tests for S/R algorithms
This commit introduces simple unit test cases for the S/R (Sender and Receiver) versions of the parallel algorithms where they did not exist yet. Note that this is only the first part of these additional test cases, they have not been implemented for every algorithm yet.
Configuration menu - View commit details
-
Copy full SHA for 79d0fbc - Browse repository at this point
Copy the full SHA 79d0fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0314c06 - Browse repository at this point
Copy the full SHA 0314c06View commit details
Commits on May 25, 2024
-
Change usages of tt::sync_wait to function calls
All usages of the tt::sync_wait sender consumer in the recently added unit tests were replaced with equivalent function calls in order to make the tests compatible with NVIDIA's stdexec.
Configuration menu - View commit details
-
Copy full SHA for 56b7249 - Browse repository at this point
Copy the full SHA 56b7249View commit details
Commits on May 28, 2024
-
Add the remaining S/R test cases
This commit adds the remaining sender adaptor test cases. As of now, it is not planned to add further test cases, as test cases were added to all the algorithms where they are currently of interest.
Configuration menu - View commit details
-
Copy full SHA for dadf073 - Browse repository at this point
Copy the full SHA dadf073View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75605fe - Browse repository at this point
Copy the full SHA 75605feView commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e5a7f75 - Browse repository at this point
Copy the full SHA e5a7f75View commit details
Commits on Jul 9, 2024
-
Fix S/R adaptors of some parallel algorithms
This commit introduces a first batch of fixes for the S/R versions of some parallel algorithms. However, they are currently all build on a temporary solution for an issue in the "then sender" and therefore not final yet.
Configuration menu - View commit details
-
Copy full SHA for 9405f50 - Browse repository at this point
Copy the full SHA 9405f50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2baa8be - Browse repository at this point
Copy the full SHA 2baa8beView commit details -
- Fly-by: comment out sender tests for algorithms that are not fixed yet
Configuration menu - View commit details
-
Copy full SHA for 5aa62d6 - Browse repository at this point
Copy the full SHA 5aa62d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679c8ac - Browse repository at this point
Copy the full SHA 679c8acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f3738a - Browse repository at this point
Copy the full SHA 1f3738aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3248db - Browse repository at this point
Copy the full SHA f3248dbView commit details
Commits on Jul 29, 2024
-
Squash merge PR STEllAR-GROUP#6431, switching to NVIDIA's S/R impleme…
…ntation Co-authored-by: isidorostsa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 83a180f - Browse repository at this point
Copy the full SHA 83a180fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4b3eb9 - Browse repository at this point
Copy the full SHA e4b3eb9View commit details -
Add guard against invocables returning booleans
The guard prevents the use of invocables returning bool in the bulk_async_execute method of the explicit_scheduler_executor to avoid data races. Using such invocables can cause issues because std::vector<return type of the invocable> may be simultaneously written to by multiple threads, which is problematic with std::vector<bool> due to its space optimizations.
Configuration menu - View commit details
-
Copy full SHA for 8bf92e8 - Browse repository at this point
Copy the full SHA 8bf92e8View commit details -
Fix S/R adaptors of more parallel algorithms
This commit introduces a new set of fixes for the S/R versions of several more parallel algorithms and reworks of some previous, buggy fixes. Additionally, new unit test cases have been added for some of the algorithms to cover edge cases such as empty ranges in case they could become pitfalls for the S/R adaptations. This led to the discovery of some general bugs in the algorithms, which were fixed as flybys: * `first_first_of` (+ regression test case) * `ends_with`
Configuration menu - View commit details
-
Copy full SHA for ffd7842 - Browse repository at this point
Copy the full SHA ffd7842View commit details -
Configuration menu - View commit details
-
Copy full SHA for 087c8b2 - Browse repository at this point
Copy the full SHA 087c8b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a101036 - Browse repository at this point
Copy the full SHA a101036View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65e35d8 - Browse repository at this point
Copy the full SHA 65e35d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03cc5aa - Browse repository at this point
Copy the full SHA 03cc5aaView commit details
Commits on Jul 30, 2024
-
Upgrade CircleCI build environment
`stellargroup/build_env:14` uses Clang 10, which lacks support for `std::identity`, a type explicitly required for enabling stdexec in HPX. Since `stellargroup/build_env:16` uses Clang 12, switching to it should resolve this issue.
Configuration menu - View commit details
-
Copy full SHA for 22e5bc3 - Browse repository at this point
Copy the full SHA 22e5bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a60d958 - Browse repository at this point
Copy the full SHA a60d958View commit details -
Try experimental, temporary CircleCI fix
This experimental fix uses an updated version of the build environment to address the issues arising with Clnag-Format 12. Additionally, as flybys, the compiler and the tools were upgraded to their most recent versions. This build environment might therefore not be suitable for getting merged and may be reverted in future commits.
Configuration menu - View commit details
-
Copy full SHA for c41aac7 - Browse repository at this point
Copy the full SHA c41aac7View commit details -
Temporarily adjust clang-tidy config
This temporary commit disables that clang-tidy treats warnings as errors. The reason for this is that the upgraded clang-tidy reports many new warnings in various parts of HPX, causing the compilation to fail, and addressing this is probably out of this PR's scope.
Configuration menu - View commit details
-
Copy full SHA for 30d71fb - Browse repository at this point
Copy the full SHA 30d71fbView commit details
Commits on Jul 31, 2024
-
Temporarily disable clang-tidy, clang-format
This commit temporarily disables clang-tidy and clang-format in CircleCI to make the CI usable for this PR. These changes will therefore be reverted later. Additionally, the spelling mistakes were fixed and the Python dependencies in the build environment adapted, so that building the documentation should work again.
Configuration menu - View commit details
-
Copy full SHA for 6880e02 - Browse repository at this point
Copy the full SHA 6880e02View commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e193798 - Browse repository at this point
Copy the full SHA e193798View commit details -
Temporarily disable work requesting scheduling policy
stdexec's implementation of sync_wait blocks the entire OS thread, in accordance with P2300 [exec.sync.wait]. Without work stealing, this causes deadlocks at the PX-thread level, leading to timeouts in many of the sender-related tests. In the long term, this should probably be fixed by implementing a custom sync_wait for HPX that is compatible with stdexec's senders.
Configuration menu - View commit details
-
Copy full SHA for c4f5276 - Browse repository at this point
Copy the full SHA c4f5276View commit details
Commits on Aug 6, 2024
-
Fix S/R adaptors of more parallel algorithms
Flyby: fix bugs in `includes` and `search` algorithms
Configuration menu - View commit details
-
Copy full SHA for 1085a10 - Browse repository at this point
Copy the full SHA 1085a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for c590cdd - Browse repository at this point
Copy the full SHA c590cddView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecfaf5c - Browse repository at this point
Copy the full SHA ecfaf5cView commit details
Commits on Aug 8, 2024
-
Fix S/R adaptors of more parallel algorithms
Flyby: Fix bug in `mismatch` algorithm
Configuration menu - View commit details
-
Copy full SHA for f20e649 - Browse repository at this point
Copy the full SHA f20e649View commit details
Commits on Aug 9, 2024
-
This macro was introduced for usage in some of the algorithm fixes, but is actually unnecessary as one can simply omit the parameter name.
Configuration menu - View commit details
-
Copy full SHA for 568201c - Browse repository at this point
Copy the full SHA 568201cView commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2baf86 - Browse repository at this point
Copy the full SHA e2baf86View commit details
Commits on Aug 17, 2024
-
Fix S/R version of rotate_copy
Fly-by: Reenable S/R unit test for rotate
Configuration menu - View commit details
-
Copy full SHA for 1dcd257 - Browse repository at this point
Copy the full SHA 1dcd257View commit details
Commits on Aug 18, 2024
-
Remove currently pointless S/R unit tests
Remove the S/R unit tests of the algorithms that are not fixed yet, since they will fail anyways and currently only pollute the test folder. To resume work on these tests in the future, simply revert this commit.
Configuration menu - View commit details
-
Copy full SHA for a20f1b4 - Browse repository at this point
Copy the full SHA a20f1b4View commit details -
Conditionally disable S/R algorithm unit tests
The unit tests for the S/R versions of the parallel algorithms are only configured if HPX_WITH_STDEXEC is enabled. Additionally, the tests cases that are in headers shared with the non-S/R tests are surrounded with macro guards checking if stdexec is available.
Configuration menu - View commit details
-
Copy full SHA for 3443586 - Browse repository at this point
Copy the full SHA 3443586View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15b4be5 - Browse repository at this point
Copy the full SHA 15b4be5View commit details -
Make minor adjustments in unit tests
* Add missing headers * Update copyright comments * Make formatting and naming more consistent
Configuration menu - View commit details
-
Copy full SHA for e0178e3 - Browse repository at this point
Copy the full SHA e0178e3View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1cfafee - Browse repository at this point
Copy the full SHA 1cfafeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a219c74 - Browse repository at this point
Copy the full SHA a219c74View commit details
Commits on Aug 20, 2024
-
Revert squash merging PR STEllAR-GROUP#6431
This reverts commit 83a180f.
Configuration menu - View commit details
-
Copy full SHA for 2f41d32 - Browse repository at this point
Copy the full SHA 2f41d32View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4aad3a - Browse repository at this point
Copy the full SHA c4aad3aView commit details -
Remove S/R tests from CircleCI targets
Flyby: Fix formatting issues
Configuration menu - View commit details
-
Copy full SHA for c2afce0 - Browse repository at this point
Copy the full SHA c2afce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c24595 - Browse repository at this point
Copy the full SHA 1c24595View commit details -
Revert remaining unrelated changes
This commits reverts other changes that are not related to the aims of this PR, but which were not undone by the previous git reverts.
Configuration menu - View commit details
-
Copy full SHA for 5a2d965 - Browse repository at this point
Copy the full SHA 5a2d965View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46a4883 - Browse repository at this point
Copy the full SHA 46a4883View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0344d00 - Browse repository at this point
Copy the full SHA 0344d00View commit details
Commits on Aug 28, 2024
-
Accommodate removal of transfer_just
`transfer_just` was removed in the 10th revision of P2300, this commit replaces its usage in the `explicit_scheduler_executor`.
Configuration menu - View commit details
-
Copy full SHA for e35074d - Browse repository at this point
Copy the full SHA e35074dView commit details