Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the S/R versions of the for loop algorithms #6529

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zhekemist
Copy link
Contributor

This PR is an extension of PR #6494, adding unit tests and fixes for the S/R versions of the following algorithms:

  • hpx::experimental::for_loop
  • hpx::experimental::for_loop_n
  • hpx::experimental::for_loop_strided
  • hpx::experimental::for_loop_n_strided

In addition, hpx::experimental::induction has been modified to be thread-safe, similar to hpx::experimental::reduction, to solve the data races that occur when used with S/R.

This commit replicates certain files and changes from
the parent pull request (STEllAR-GROUP#6494) to ensure that both
PRs are independent of each other, with each based on
current the master branch.
@StellarBot
Copy link

Can one of the admins verify this patch?

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% 97.92%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9931d2f) 223277 189925 85.06%
Head commit (c77751f) 191669 (-31608) 163207 (-26718) 85.15% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6529) 432 423 97.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants