Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTIME] Prevents SysTimeToMs computations that may cause miscalculations when calendarTime is too large #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wdfk-prog
Copy link

No description provided.

@ALABSTM ALABSTM added bug Something isn't working mw Middleware-related issue or pull-request. lorawan Long Range Wide Area Network labels May 13, 2024
@RJMSTM
Copy link
Contributor

RJMSTM commented May 15, 2024

ST Internal Reference: 181479

@RJMSTM RJMSTM added the internal bug tracker Issue confirmed and logged into the internal bug tracking system label May 15, 2024
@RJMSTM
Copy link
Contributor

RJMSTM commented Feb 12, 2025

Hello @wdfk-prog,

Thank you for your contribution. You have proposed three changes, detailed as follows:

  1. "[LoRaMac ProcessRadioTxDone] Optimize code reading and execution conditions"
  • We cannot accept this change because we aim to implement a better solution, the condition if(MacCtx.NodeAckRequested == false) is evaluated for every LORAMAC_VERSION, and we plan to move this check elsewhere.
  1. "[LoRaMac] Add SendInfo function and GetMaxPayloadLength function for use by the outer layer"
  • We cannot accept this change as it is considered a custom solution rather than a general one.
  1. "[SYSTIME] Prevents SysTimeToMs computations that may cause miscalculations when calendarTime is too large"
  • Could you provide more details? Specifically, we need clarification on the module operation with 4194304000.

Regards,

@RJMSTM RJMSTM added the needs clarification Needs clarification or inputs from the user label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal bug tracker Issue confirmed and logged into the internal bug tracking system lorawan Long Range Wide Area Network mw Middleware-related issue or pull-request. needs clarification Needs clarification or inputs from the user
Projects
Development

Successfully merging this pull request may close these issues.

3 participants