Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radium dataflow rendering #1018

Draft
wants to merge 239 commits into
base: release-candidate
Choose a base branch
from

Conversation

MathiasPaulin
Copy link
Contributor

@MathiasPaulin MathiasPaulin commented Nov 4, 2022

Pull Request Description

This PR is a draft for Node base rendering in Radium.
It extends the PR #1007 with dedicated nodes for rendering and a new type of renderer.
This PR will be rebased (and then force pushed) on any changes in PR #1007
Note that this PR only adds 17 files to the PR #1007 (whose number of files should decrease by removing examples duplicated in unittests)

This PR is stills draft as under heavy work (porting from prototype to the PR)

Right now, the system is quite fonctionning with only a few rendering nodes available

FirstNodeRendering

TODO

  • Add more rendering nodes
  • Add compositing nodes
  • Add image processing nodes
  • Allow renderers to execute several graphs ( e.g. one per Ro types ) before compositing their results
  • Simplify and review code
  • Docs, tests, ...

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1018 (ab4b5da) into release-candidate (fe7d934) will increase coverage by 1.15%.
The diff coverage is 53.31%.

❗ Current head ab4b5da differs from pull request most recent head 66c36f9. Consider uploading reports for the commit 66c36f9 to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1018      +/-   ##
=====================================================
+ Coverage              45.65%   46.81%   +1.15%     
=====================================================
  Files                    312      390      +78     
  Lines                  23060    27333    +4273     
=====================================================
+ Hits                   10529    12797    +2268     
- Misses                 12531    14536    +2005     
Impacted Files Coverage Δ
src/Dataflow/Core/Enumerator.hpp 0.00% <0.00%> (ø)
...ataflow/QtGui/GraphEditor/ConnectionStatusData.hpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/GraphEditorView.cpp 0.00% <0.00%> (ø)
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.cpp 0.00% <0.00%> (ø)
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.hpp 0.00% <0.00%> (ø)
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.cpp 0.00% <0.00%> (ø)
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.hpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/WidgetFactory.cpp 0.00% <0.00%> (ø)
src/Dataflow/QtGui/GraphEditor/WidgetFactory.hpp 0.00% <0.00%> (ø)
...Dataflow/Rendering/Nodes/AntiAliasing/FxaaNode.cpp 0.00% <0.00%> (ø)
... and 74 more

... and 2 files with indirect coverage changes

@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 4 times, most recently from 229b972 to c1d4d3f Compare November 8, 2022 13:57
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 12 times, most recently from c6d82fc to 1e73305 Compare February 6, 2023 13:59
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 2 times, most recently from adc30c9 to 3948560 Compare February 13, 2023 16:13
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 3 times, most recently from 1e2be62 to 25142de Compare February 27, 2023 11:26
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 3 times, most recently from 50a585c to d27d5d7 Compare March 24, 2023 07:51
@MathiasPaulin MathiasPaulin force-pushed the Radium-dataflow-rendering branch 4 times, most recently from 8c23496 to 14d958f Compare April 4, 2023 11:34
MathiasPaulin and others added 29 commits June 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants