Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material in core #1050

Draft
wants to merge 17 commits into
base: release-candidate
Choose a base branch
from

Conversation

MathiasPaulin
Copy link
Contributor

Pull Request Desription

This is a very early, and very incomplete) proposal to bring material data into Radium Core and improve interface for CPU usage.
Works right now with very limited functionalities.

TODO

  • improve class Core::Tex to manage texture, or rely on openimageio
  • declare (and implement) bsdf specific interface in material model :
    • bsdf (eval), taking w_i, w_o, N, uv as parameter and return the bsdf value for this configuration
    • sample : taking w_o, N, uv as parameter and return (w_i, pdf) of the generated direction
    • pdf , taking w_i, w_o, N, uv as parameter and return the probability of w_i wrt w_o, N, uv

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/master AND to have linear history (i.e. no merge commit).
  • Update your git repository git fetch origin if origin is this remote
  • Check with the script provided in scripts/is-history-pr-compatible.sh
  • You must use clang-format style
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other:
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant