Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gpu linear blend skinning #1077

Draft
wants to merge 3,066 commits into
base: release-candidate
Choose a base branch
from
Draft

Gpu linear blend skinning #1077

wants to merge 3,066 commits into from

Conversation

ntsh-oni
Copy link

@ntsh-oni ntsh-oni commented Mar 4, 2024

Pull Request Description

This pull request is about Linear Blend Skinning on GPU. It is currently done on CPU at the moment, as the vertices are modified on CPU, but doing it on GPU could introduce a speedup.

The feature is not ready yet, issues with Skeletal Components and passing data to different vertex shaders.

  • What kind of change does this PR introduce?

    • feature

  • What is the current behavior?

Linear blend skinning is performed on CPU.

  • What is the new behavior (if this is a feature change)?

Linear blend skinning would be performed on GPU.

dlyr and others added 30 commits November 16, 2022 08:18
@dlyr
[examples] Use keymapping without modifiers.
ce0eddd
@dlyr
[doc] Improve KeyMappingManager doc with cleaner snippets.
13ea5f4
@dlyr
[gui] clean viewer commented lines.
4c5acd6
@dlyr
Merge pull request STORM-IRIT#906 from dlyr/exposeBinding
03330bf 
Expose binding
@github-actions
Update version to 1.3.12 [skip ci]
dd64288
@dlyr
[core] Fix taskQueue worker starts while runInThisThread.
df19a63
@dlyr
[core] Allow no thread task queue, and use 2nd form of wait.
b40cbec
@dlyr
[engine] gpuTaskQueue has no threads.
40ec570
@dlyr
[examples] Add a second thread in TexturedQuadDynamic.
6a01296
@dlyr
[core] TaskQueue lock guard task list modifications.
6715c39
@dlyr @nmellado
[core] typo in comment TaskQueue.hpp
5564ae3 
Co-authored-by: Nicolas Mellado <[email protected]>
@dlyr
[core] move lock before assert in addDependency TaskQueue.cpp
c10e543
@dlyr
[core] Rephrase doc in TaskQueue.hpp
1b91655
@dlyr
[core] clean include and move lock in TaskQueue.cpp
d55d2f6
@hiergaut @dlyr
[examples] Stops second when quit TexturedQuadDynamic.
6944e47
@dlyr
Merge pull request STORM-IRIT#1024 from dlyr/fix-task-queue
a3d0593 
Fix STORM-IRIT#1023
@github-actions
Update version to 1.3.13 [skip ci]
fc8fc24
@MathiasPaulin
[core] Add generic variable set
f447977
@MathiasPaulin
[core] fix codacy bad reporting
550a3f8
@MathiasPaulin
[unittests][core] test generic variable set
166ccfc
@MathiasPaulin
Merge pull request STORM-IRIT#1022 from MathiasPaulin/core-variables
ffc1bf4 
Core variables
@github-actions
Update version to 1.3.14 [skip ci]
fa88b85
@dlyr
[engine] guard empty m_animations access.
8408906
@dlyr
[engine] Add get/set bone transformation using boneIdx.
cc5af82
@dlyr
[engine] add mesh name, bone weight, bone bind matrix setters.
09e9b71
@dlyr
[core] use isinfinite instead of isnormal to check invalid numbers.
76f0b1d 
isnormal return false for 0., not sure 0. has to be considered invalid (e.g. for skinning weight).
@dlyr
[core] Add makeSharpCylinder, with side segment specification.
79f01fa
@dlyr
[core] Add smoothstep template (as in glsl).
d953f0f
@dlyr
[examples] simple skinning example.
314e16f
@dlyr
[engine] Add doc to new methods in SkinningComponent.
b5d1833
dlyr and others added 29 commits April 6, 2023 18:59
@dlyr
[engine] Add empty ctor.
d36fbc0
@dlyr
[engine] use geometrydisplayable for components.
92fd804
@dlyr
[engine] rename correspondance -> matching
7d25da6 
[engine] mesh override getNumVertices for GeometryDisplayable.

remove uneeded export api on template
@dlyr
[engine] GeometrySystem use GeometryDisplayable comp.
d6015ad
@dlyr
[examples] Start using GeometryDisplayable in draw prim.
3741bf2
@dlyr
[engine] GeometryComponent clean include.
d06fed2
@dlyr
[engine] Renderer remove debug print.
fd3ea55 
remove forward old draw wireframe
@dlyr
[engine] handle line index layer picking render mode.
ed01e2d 
[engine] Mesh remove debug print.

remove mesh debug message

 print mesh name on invalid layer
@dlyr
[core] MeshPrimitives remove debug print.
9b488b9
@dlyr
[core] IndexedGeometry remove debug print.
3560eca
@dlyr
[examples] HelloRadium remove debug print.
a3ad0a5
@dlyr
[engine] Remove unused LineMeshComponent.
78c3db9
@dlyr
[examples] add fixed light in skinning example.
074d331
@dlyr
[core] use inverse transpose for normal lbs.
a14f4da
@dlyr
[core] comment typo in trianglemesh
269e2b2
@dlyr
[core][engine] use AttribArrayGeometry as skinning data.
420be76 
tmp disable rotation center skinning
@dlyr
[core] register rw on AttribArrayGeometry for SurfaceMeshComponent.
5ac4410
@dlyr
Merge branch 'curve-editor-example-app' into release-candidate
7a54114
@dlyr
[external] Fix pass Qt version to external build.
271bdbd
@dlyr
Merge branch 'fix-external-qt-version' into paintyVersionRpRb
485590f
@dlyr
[core] Export VariableSetFunctions.
a02b6b5
fix msvc warning
de5cfb2
add missing exports
7bc86f7
remove copy of unexisting assets
172f7ff
msvc error on capture ? to revert
e62fe7e
start linear blend skinning on gpu
0a235a9
add lbs to blinn phong vertex shader
e95c5c5
@ntsh-oni
build render technique
4fec4f3
@ntsh-oni
do not update vertices on CPU if the skinning types uses the GPU and …
a5f4052 
…fix a maximum joints count in LBS shader
@dlyr dlyr marked this pull request as draft July 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ntsh-oni @dlyr @hiergaut @MathiasPaulin @nmellado @Mafo369