Small fixes and improvement. #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ease copy paste.
It's not an error, and enforcing is prone to error (e.g. missing enum value case).
double brace array initializer, suffix shadow variable with underscore.
To have absolute includes in moc.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-candidate #1078 +/- ##
=====================================================
- Coverage 46.75% 46.72% -0.03%
=====================================================
Files 316 316
Lines 23255 23246 -9
=====================================================
- Hits 10872 10861 -11
- Misses 12383 12385 +2 ☔ View full report in Codecov by Sentry. |
MathiasPaulin
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Related to coverage, it was not working on my side, maybe related to qt6 moc, but I did not dig more than that to find why.
[cmake] CMAKE_AUTOMOC_PATH_PREFIX to fix coverage.
[cmake] Update coverage exclude and basedir.
[cmake] updates CodeCoverage.cmake according to upstream and local fixes.
[cmake] Code coverage verbose message without STATUS.
[tests][cmake] parrallel ctest.
About warnings
[core][engine][headless][tests] fix warnings.
[cmake] do not warn missing default on switch.
Apout cli
[examples] use CLI getter (now member variable is private).
[headless] split Viewer/RadiumEngine CLI App to have CLI without renderer.
Enhancement
[core] add allClose in math function.
Fixes and typo
[gui] add missing viewer's delete pickingManager.
[engine] typo programm -> program.
[engine] Fix out of bound image read.
On the CLIViewer, since data member need to be accessed with getters/setters