Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve editor example app #967

Draft
wants to merge 19 commits into
base: release-candidate
Choose a base branch
from

Conversation

dlyr
Copy link
Contributor

@dlyr dlyr commented Jul 15, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add a piecewise cubic Bezier class and a new example app of a curve editor.

  • What is the current behavior? (You can also link to an open issue here)
    Not existing.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    None.

  • Other information:
    This PR is based on the PR Fix assets #966
    A getter of the brush radius had to be added to the renderer.

@dlyr dlyr force-pushed the curve-editor-example-app branch from 01e02ec to 92c9b8b Compare July 15, 2022 08:38
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #967 (d3a2bbe) into release-candidate (4dcf7d0) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

❗ Current head d3a2bbe differs from pull request most recent head e11bb2e. Consider uploading reports for the commit e11bb2e to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate     #967      +/-   ##
=====================================================
- Coverage              45.65%   45.36%   -0.30%     
=====================================================
  Files                    312      314       +2     
  Lines                  23060    23209     +149     
=====================================================
  Hits                   10529    10529              
- Misses                 12531    12680     +149     
Impacted Files Coverage Δ
src/Core/Geometry/Curve2D.cpp 0.00% <0.00%> (ø)
src/Core/Geometry/Curve2D.hpp 0.00% <0.00%> (ø)
src/Engine/Rendering/Renderer.hpp 7.27% <0.00%> (-0.42%) ⬇️

... and 1 file with indirect coverage changes

@dlyr dlyr force-pushed the curve-editor-example-app branch from 92c9b8b to 2f64c4b Compare July 15, 2022 12:41
@dlyr dlyr mentioned this pull request Jul 17, 2022
3 tasks
@nmellado nmellado added Feature Request Type of issue: feature request GUI Related to Ra::Gui Core Related to Ra::Core demos Related to embedded demo applications and removed GUI Related to Ra::Gui labels Jul 22, 2022
@nmellado nmellado marked this pull request as draft October 5, 2022 12:09
@dlyr dlyr force-pushed the curve-editor-example-app branch 2 times, most recently from ec07912 to 167ad8d Compare April 7, 2023 06:26
@dlyr dlyr force-pushed the curve-editor-example-app branch from 6a9efcb to 1d0bbc9 Compare July 10, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Ra::Core demos Related to embedded demo applications Feature Request Type of issue: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants