Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVCAMP-275 | Add support for linking to assets; tighten padding for basic page hero #187

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Jan 10, 2024

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • Add support for linking to assets uploaded to Storyblok
  • tighten padding for basic page hero

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Go to https://deploy-preview-187--giving-campaign.netlify.app/stories/education-for-a-life-of-purpose

  2. Scroll to the banner near the footer
    Screenshot 2024-01-09 at 4 18 55 PM

  3. Check that the link to the PDF in the button has the assets.stanford.edu domain. Check that you can click on it and go to the pdf.

  4. Go to https://deploy-preview-187--giving-campaign.netlify.app/newsletter/sign-up

  5. Check out the smaller vertical padding on the hero

Associated Issues and/or People

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 421cf89
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/659def388d955b0008bd0b5f
😎 Deploy Preview https://deploy-preview-187--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu marked this pull request as ready for review January 10, 2024 00:20
@yvonnetangsu yvonnetangsu changed the title GIVCAMP-275 | Add support for linking to assets GIVCAMP-275 | Add support for linking to assets; tighten padding for basic page hero Jan 10, 2024
@yvonnetangsu
Copy link
Member Author

@sherakama is out for the day. Time to merge mwahaha 😆
Please review retro if needed but pretty straightforward one

@yvonnetangsu yvonnetangsu merged commit c0d1ffb into dev Jan 10, 2024
4 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/GIVCAMP-275_asset-links branch January 10, 2024 01:48
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants