Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA | Remove currently unused and POC components #390

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Feb 19, 2025

READY FOR REVIEW

Summary

  • Remove currently unused components include POC work
  • Clean up logo related components and move them all under the Logo directory

Review By (Date)

  • Retro

Criticality

  • 2

Review Tasks

Setup tasks and/or behavior to test

  1. Look at what's removed/changed in the code
  2. Take a look at the preview and make sure things still look the same.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit d21bfc6
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/67b531f38717490008afd093
😎 Deploy Preview https://deploy-preview-390--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu marked this pull request as ready for review February 19, 2025 01:21
@yvonnetangsu
Copy link
Member Author

@sherakama Just doing some maintenance and remove unused things. I'll merge this into dev so my video looping PR will only have video related changes and not thousands of code removed 😂

@yvonnetangsu yvonnetangsu merged commit 752d816 into dev Feb 19, 2025
5 checks passed
@yvonnetangsu yvonnetangsu deleted the nojira-remove-unused branch February 19, 2025 01:27
yvonnetangsu added a commit that referenced this pull request Feb 19, 2025
* dev:
  NOJIRA | Remove currently unused and POC components (#390)
@sherakama
Copy link
Member

Screenshot 2025-02-19 at 11 22 00

Woo, that was a decent cut.

@yvonnetangsu
Copy link
Member Author

Screenshot 2025-02-19 at 11 22 00

Woo, that was a decent cut.

Mari Kondo style 😆

@yvonnetangsu yvonnetangsu mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants