Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for newer versions of Python, NumPy #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WardLT
Copy link

@WardLT WardLT commented Oct 10, 2023

This PR fixes a few issues that CatKit has with newer versions of Python and NumPy

  • Move the location of MutableMappings
  • Ensure that NumPy creates a non-rectangular array with provided with a sequence of sequences

I also fixed a few other bugs:

sklearn is just a placeholder for scikit-learn and
not an actual Python package
NumPy must have changed how arrays of sequences are created
at somepoint in the past. I cannot find it in the change log,
but the change I suggest should work across numpy versions
@WardLT WardLT requested a review from jboes as a code owner October 10, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant