Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2 APIs specific for user name and user language #703

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

alessandrodi
Copy link
Contributor

@alessandrodi alessandrodi commented Sep 26, 2024

splitted update_personal_data() into 2 APIs: update_user_name() and update_user_language()

@alessandrodi alessandrodi changed the title splitted update_personal_data() into 2 APIs: update_user_name() and u… Create 2 API specific for user name and user language Sep 26, 2024
@alessandrodi alessandrodi changed the title Create 2 API specific for user name and user language Create 2 APIs specific for user name and user language Sep 26, 2024
src/eduid/webapp/personal_data/views.py Outdated Show resolved Hide resolved
src/eduid/webapp/personal_data/views.py Outdated Show resolved Hide resolved
src/eduid/webapp/personal_data/views.py Show resolved Hide resolved
src/eduid/webapp/personal_data/schemas.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@johanlundberg johanlundberg merged commit d2ff076 into main Sep 27, 2024
10 of 11 checks passed
@johanlundberg johanlundberg deleted the alex-split-language-name-api branch September 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants