tidy up IDE complaints

src/auth_server/proof/jws.py

@@ -124,11 +124,9 @@ async def check_jwsd_proof(
         # rebuilding the request as that was what was signed
         assert isinstance(gnap_request_orig.client, Client)  # please mypy
         gnap_request_orig.client.key = key_reference
-        payload = base64url_encode(gnap_request_orig.json(exclude_unset=True))
-    else:
-        payload = base64url_encode(gnap_request_orig.json(exclude_unset=True))
 
     logger.debug(f"gnap_request_orig: {gnap_request_orig.json(exclude_unset=True)}")
+    payload = base64url_encode(gnap_request_orig.json(exclude_unset=True))
     raw_jws = f"{header}.{payload}.{signature}"
     _jws = jws.JWS()
 

src/auth_server/saml2.py

@@ -294,7 +294,7 @@ async def process_assertion(saml_response: str) -> Optional[AssertionData]:
     logger.debug(f"authn response: {response}")
 
     if authn_ref not in saml2_sp.authn_req_cache:
-        logger.info(f"Unknown response")
+        logger.info("Unknown response")
         raise BadSAMLResponse("Unknown response")
 
     session_info = SessionInfo.from_pysaml2(response.session_info())

src/auth_server/tests/test_app.py

@@ -278,7 +278,7 @@ def test_transaction_jws(self):
         data = _jws.serialize(compact=True)
 
         client_header = {"Content-Type": "application/jose+json"}
-        response = self.client.post("/transaction", data=data, headers=client_header)
+        response = self.client.post("/transaction", content=data, headers=client_header)
 
         assert response.status_code == 200
         assert "access_token" in response.json()
@@ -309,7 +309,7 @@ def test_transaction_jwsd(self):
         data = _jws.serialize(compact=True)
 
         # Remove payload from serialized jws
-        header, payload, signature = data.split(".")
+        header, _, signature = data.split(".")
         client_header = {"Detached-JWS": f"{header}..{signature}"}
 
         response = self.client.post("/transaction", json=req.dict(exclude_unset=True), headers=client_header)