Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mdemare committed Dec 10, 2024
1 parent cb3f73c commit c39ef35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
6 changes: 2 additions & 4 deletions src/nl/surf/eduhub_rio_mapper/cli_commands.clj
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
(:require [clojure.data.json :as json]
[clojure.java.io :as io]
[clojure.string :as str]
[nl.jomco.envopts :as envopts]
[nl.surf.eduhub-rio-mapper.clients-info :as clients-info]
[nl.surf.eduhub-rio-mapper.config :as config]
[nl.surf.eduhub-rio-mapper.endpoints.api :as api]
Expand Down Expand Up @@ -121,10 +122,7 @@
(resolver type id (:institution-oin client-info)))

"document-env-vars"
(let [x (map (fn [[k v]] [(-> k name str/upper-case (str/replace #"-" "_")) (first v)]) config/opts-spec)
max-env-length (last (sort (map #(count (first %)) x)))
output (map (fn [[env desc]] (str env " " (apply str (repeat (- max-env-length (count env) -1) " ")) desc)) x)]
(str/join "\n" (sort output)))
(envopts/specs-description config/opts-spec)

("upsert" "delete" "delete-by-code")
(let [[client-info [type id rest-args]] (parse-client-info-args args clients)
Expand Down
1 change: 0 additions & 1 deletion src/nl/surf/eduhub_rio_mapper/config.clj
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@
(assoc :clients (clients-info/read-clients-data clients-info-config)))))))

(defn make-config-and-handlers []
(println "make-config-and-handlers")
(let [{:keys [clients] :as cfg} (make-config)
handlers (processing/make-handlers cfg)
config (update cfg :worker merge
Expand Down

0 comments on commit c39ef35

Please sign in to comment.