More regression tests #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joodie
requested changes
Jan 15, 2024
| @@ -45,12 +45,14 @@ | |||
| (def aangeboden-opleiding-namen | |||
| #{:aangebodenHOOpleidingsonderdeel :aangebodenHOOpleiding :aangebodenParticuliereOpleiding}) | |||
|
|
|||
| ;; NOTE: aangeboden opleidingen are reference by OOAPI UID | |||
| :retryable? false}))) | ||
|
|
||
| (let [soap-action (str "opvragen_" type) | ||
| rio-sexp (condp = type | ||
| ;; Command line only. | ||
| opleidingseenheden-van-organisatie | ||
| [[:duo:onderwijsbestuurcode id] | ||
| [[:duo:onderwijsbestuurcode opleidingscode] ;; FIXME: this is not an opleidingscode! |
There was a problem hiding this comment.
Waarom is deze verandering er dan?
There was a problem hiding this comment.
Omdat het stuk is zonder deze aanpassing. De FIXME heb ik toegevoegd omdat het hier natuurlijk om een bestuurcode gaat en er dus heel slordig gewoon een property misbruikt wordt.
|
|
||
| (def ^:private last-boxed-print (atom nil)) | ||
|
|
||
| (defmacro print-boxed | ||
| "Print pretty box around output of evaluating `form`." | ||
| [title & form] | ||
| `(let [s# (with-out-str (do ~@form))] | ||
| `(let [r# (transient []) |
There was a problem hiding this comment.
Useless binding is overwritten at line 40
| (concat result (f file)) | ||
| (conj result file))) | ||
| result)))] | ||
| (f (entities-dir)))) |
There was a problem hiding this comment.
Als je f als named functie extract, kan je die loop ook omzetten in mapcat
| ;; scenario [8b]: Test /job/link to reset the course to the old 'eigen sleutel'. | ||
| :TODO) | ||
| (testing "scenario [7a]: Test /job/upsert with the edspec for a course. You can expect 'done'." | ||
| (let [job (post-job :upsert :education-specifications "parent-course")] |
There was a problem hiding this comment.
Ik vind "parent-course" wel een verwarrende naam voor een education specification. Vooral als de course dan weer gewoon "some" heet...
remvee
force-pushed
the
more-regression-tests
branch
2 times, most recently
from
59561dd to
9a5fb1d
Compare
remvee
force-pushed
the
more-regression-tests
branch
from
9a5fb1d to
e7856eb
Compare
remvee
force-pushed
the
more-regression-tests
branch
from
e7856eb to
b4ed154
Compare
joodie
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.