Schedule should use UTC; fixed name job #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remvee
requested changes
Jun 11, 2024
project.clj
Outdated
| @@ -92,4 +92,4 @@ | |||
| :e2e :e2e | |||
| :all (constantly true)} | |||
|
|
|||
| :repl-options {:init-ns nl.surf.eduhub-rio-mapper.ooapi}) | |||
| :repl-options {:init-ns nl.surf.eduhub-rio-mapper.specs.ooapi}) | |||
There was a problem hiding this comment.
Waarom hebben we dit uberhaupt? Kan dit niet gewoon weg?
There was a problem hiding this comment.
Zonder werkt inderdaad ook prima
.github/workflows/test-rio.yml
Outdated
| @@ -2,10 +2,10 @@ name: Check if RIO queue is up or down | |||
|
|
|||
| on: | |||
| schedule: | |||
| - cron: '6 9-17 * * 1-5' # every hour on weekdays during working hours | |||
| - cron: '6 7-15 * * 1-5' # every hour on weekdays during working hours | |||
There was a problem hiding this comment.
Kunnen we niet beter voor 9-15 gaan? Dan weten we zeker dat het kantooruren in onze TZ zijn.
There was a problem hiding this comment.
Nog beter, laten we de precieze check in Clojure doen waar we wel weten hoe laat het is, zodat we het hele jaar alleen tussen 9:00 en 17:00 testen, zomertijd en wintertijd.
remvee
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.