Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed limit on admissionRequirements #312

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Removed limit on admissionRequirements #312

merged 2 commits into from
Jun 12, 2024

Conversation

mdemare
Copy link
Collaborator

@mdemare mdemare commented Jun 12, 2024

No description provided.

@mdemare mdemare force-pushed the admissionRequirements branch from 8d63359 to 3bf508e Compare June 12, 2024 09:03
@mdemare mdemare force-pushed the admissionRequirements branch from 3bf508e to e896abc Compare June 12, 2024 09:12
@mdemare mdemare requested a review from joodie June 12, 2024 10:12
(s/def ::VeryLongLanguageTypedString/language
(re-spec #"^[a-z]{2,4}(-[A-Z][a-z]{3})?(-([A-Z]{2}|[0-9]{3}))?$"))

(s/def ::VeryLongLanguageTypedString/value
Copy link
Contributor

@joodie joodie Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geen idee of 10000 chars genoeg is.... Ik denk dat voor dit veld we beter een UnlimitedLanguageTypedString/value kunnen toevoegen (dus zonder lengte limiet), wat denk jij?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, doe ik dat.

@mdemare mdemare requested a review from joodie June 12, 2024 13:34
Copy link
Contributor

@joodie joodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prima!

@mdemare mdemare merged commit e3e3b87 into main Jun 12, 2024
6 checks passed
@mdemare mdemare deleted the admissionRequirements branch June 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants