Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In rio queue test, also test read after update #348

Merged
merged 3 commits into from
Dec 20, 2024
Merged

In rio queue test, also test read after update #348

merged 3 commits into from
Dec 20, 2024

Conversation

mdemare
Copy link
Collaborator

@mdemare mdemare commented Dec 18, 2024

Er zijn weer issues bij rio. Deze PR voegt een test op dit type issue toe aan de bestaande rio queue test.

@mdemare mdemare force-pushed the rio-test branch 2 times, most recently from 5db88e1 to ff9db60 Compare December 18, 2024 13:45
@mdemare mdemare requested a review from joodie December 18, 2024 14:40
::ooapi/entity eduspec}
rio-code (-> insert-req insert! :aanleveren_opleidingseenheid_response :opleidingseenheidcode)
link-req (merge insert-req {::ooapi/id new-uuid ::rio/opleidingscode rio-code})]
(link! link-req)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is deze link stap nodig? Of kunnen we ook alleen een 'find-rio-object' doen tegen de originele insert?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik wil niet alleen een insert testen, maar ook een update.

@mdemare mdemare requested a review from remvee December 20, 2024 13:19
@mdemare mdemare enabled auto-merge (squash) December 20, 2024 13:27
Copy link
Collaborator

@remvee remvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemare mdemare merged commit 062ee3d into main Dec 20, 2024
6 checks passed
@remvee remvee deleted the rio-test branch January 3, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants