Make hidden Type of Service field editable again #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
force-pushed
the
feature/1322-fix-service-type
branch
from
573fe05 to
7f2ff82
Compare
johanib
force-pushed
the
feature/1322-fix-service-type
branch
from
7f2ff82 to
3347b0a
Compare
johanib
changed the title
johanib
force-pushed
the
feature/1322-fix-service-type
branch
from
3347b0a to
3f7eecd
Compare
MKodde
approved these changes
Jan 27, 2025
src/Surfnet/ServiceProviderDashboard/Domain/Repository/TypeOfServiceRepositoryFromConfig.php
Outdated
Show resolved
Hide resolved
Prior to this change, the Type of Service field was hidden and not editable because users could be confused by certain internal SURF types, such as SURF or Recommended. This change hides those types from the UI and ensures they cannot be modified from SP Dashboard. Fixes #1322
johanib
force-pushed
the
feature/1322-fix-service-type
branch
from
3f7eecd to
ebb18d6
Compare
MKodde
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the Type of Service field was hidden and not
editable because users could be confused by certain internal SURF types,
such as SURF or Recommended.
This change hides those types from the UI and ensures they cannot be
modified from SP Dashboard.
Fixes #1322