Symfony 6.4 upgrade #620
Merged
Symfony 6.4 upgrade #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Recurring issues:
- I noticed a lot of commented strict_type declarations. Why did you disable them? If we are not adding strict types there, please remove them. But even better, I much prefer we enable strict typing throughout the app.
- A lot of PHPDoc type hints are still present. Please remove them and at those points I missed type definitions.
- The removal of the
if (empty($foobar))condition that you replaced with the!=='' || == '0' || ..construction does not sit right with me. I'd like to see the original to return. Or that you implement an alternative that is not so expressive.
src/Surfnet/ServiceProviderDashboard/Application/Assembler/ServiceStatusAssembler.php
Outdated
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Assembler/ServiceStatusAssembler.php
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Assembler/ServiceStatusAssembler.php
Outdated
Show resolved
Hide resolved
...erviceProviderDashboard/Application/Command/Entity/SaveOidcngResourceServerEntityCommand.php
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/UpdateEntityAclCommand.php
Outdated
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/UpdateEntityAclCommand.php
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Command/Service/CreateServiceCommand.php
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Command/Service/CreateServiceCommand.php
Show resolved
Hide resolved
MKodde
requested changes
Jan 25, 2024
...iceProviderDashboard/Application/CommandHandler/Entity/EntityChangeRequestCommandHandler.php
Outdated
Show resolved
Hide resolved
...iceProviderDashboard/Application/CommandHandler/Entity/EntityChangeRequestCommandHandler.php
Show resolved
Hide resolved
...rviceProviderDashboard/Application/CommandHandler/Entity/PublishEntityTestCommandHandler.php
Outdated
Show resolved
Hide resolved
src/Surfnet/ServiceProviderDashboard/Application/Dto/ServiceStatusDto.php
Outdated
Show resolved
Hide resolved
quartje
force-pushed
the
feature/symfony6-upgrade
branch
2 times, most recently
from
36ecc86 to
3c04dcb
Compare
MKodde
requested changes
Feb 6, 2024
There was a problem hiding this comment.
- The Test integration run is not green yet. Hangs on a lockfile issue as it seems
- I'd still like to discuss the introduction of this logic. The code maybe became more type safe that way, but readability took a big hit here IMHO.
$entity->getId() === null || $entity->getId() === '' || $entity->getId() === '0';
Perhaps we can move this check to a helper function, reinstate the old behavior, ... insert your ideas here ...
src/Surfnet/ServiceProviderDashboard/Application/Command/Entity/UpdateEntityAclCommand.php
Outdated
Show resolved
Hide resolved
parijke
force-pushed
the
feature/symfony6-upgrade
branch
from
fe57b7c to
67c979c
Compare
|
I think all rleft over review points are addressed now |
MKodde
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Ship it, my Spanish friend. Would you be so kind to:
- First rebase the recent Jira changes?
- Update the PR description
- Update the Wiki checklist
- Review the git history of this PR, you can decide to leave the log, or to squash merge them into 1. I think the log is good'enuff to merge it as is. But your the judge in the end.
- Create a new release branch for this release (and update the changelog.md accordingly)
- Tag it
parijke
force-pushed
the
feature/symfony6-upgrade
branch
from
de724aa to
5844d59
Compare
parijke
force-pushed
the
feature/symfony6-upgrade
branch
from
5844d59 to
44be7d5
Compare
Also, phpstan compains about empty return statements, so had to implement a fake return on IssueRepository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to php 8.2 and symfony 6.4
Added phpstan