Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.51.0 → 1.55.1 (minor) #1307

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 1, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.51.0 → 1.55.1) · Repo · Changelog

Release Notes

1.55.1

Bug fixes

  • #12068: Fix a false positive for Style/ReturnNilInPredicateMethodDefinition when the last method argument in method definition is nil. (@koic)
  • #12082: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for with multiple variables. (@koic)
  • #12079: Fix an error for Style/MixinGrouping when mixin method has no arguments. (@koic)
  • #11637: Correct Rubocop for private_class_method method documentation. (@bigzed)
  • #12070: Fix false positive in Style/ArgumentsForwarding when receiver forwards args/kwargs. (@owst)

1.55.0

New features

  • #11794: Add support to Style/ArgumentsForwarding for anonymous arg/kwarg forwarding in Ruby 3.2. (@owst)
  • #12044: Make LSP server support layoutMode option to run layout cops. (@koic)
  • #12056: Make LSP server support lintMode option to run lint cops. (@koic)
  • #12046: Make ReturnNilInPredicateMethodDefinition aware of nil at the end of predicate method definition. (@koic)

Bug fixes

  • #12055: Allow parentheses in single-line match patterns when using the omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #12050: Fix a false positive for Layout/RedundantLineBreak when inspecting the % form string %\n\n. (@koic)
  • #12063: Fix Style/CombinableLoops when one of the loops is empty. (@fatkodima)
  • #12059: Fix a false negative for Style/StringLiteralsInInterpolation for symbols with interpolation. (@fatkodima)
  • #11834: Fix false positive for when variable in inside conditional branch in nested node. (@alexeyschepin)
  • #11802: Improve handling of [] and () with percent symbol arrays. (@jasondoc3)
  • #12052: Fix "Subfolders can't include glob special characters". (@meric426, @loveo)
  • #12062: Fix LoadError when loading RuboCop from a symlinked location on Windows. (@p0deje)

Changes

  • #12064: Make Style/RedundantArgument aware of exit and exit!. (@koic)
  • #12015: Mark Style/HashConversion as unsafe autocorrection. (@koic)

1.54.2

Bug fixes

  • #12043: Fix a false negative for Layout/ExtraSpacing when some characters are vertically aligned. (@koic)
  • #12040: Fix a false positive for Layout/TrailingEmptyLines to prevent the following incorrect autocorrection when inspecting the % form string %\n\n. (@koic)
  • #1867: Fix an error when AllCops:Exclude is empty in .rubocop.yml. (@koic)
  • #12034: Fix invalid byte sequence in UTF-8 error when using an invalid encoding string. (@koic)
  • #12038: Output the "server restarting" message to stderr. (@knu)

1.54.1

Bug fixes

  • #12024: Fix a false positive for Lint/RedundantRegexpQuantifiers when interpolation is used in a regexp literal. (@koic)
  • #12020: This PR fixes an infinite loop error for Layout/SpaceAfterComma with Layout/SpaceBeforeSemicolon when autocorrection conflicts. (@koic)
  • #12014: Fix an error for Lint/UselessAssignment when part of a multiple assignment is enclosed in parentheses. (@koic)
  • #12011: Fix an error for Metrics/MethodLength when using a heredoc in a block without block arguments. (@koic)
  • #12010: Fix false negatives for Style/RedundantRegexpArgument when using safe navigation operator. (@koic)

1.54.0

New features

  • #12000: Support safe or unsafe autocorrect config for LSP. (@koic)

Bug fixes

  • #12005: Fix a false negative for Lint/Debugger when using debugger method inside lambda. (@koic)
  • #11986: Fix a false positive for Lint/MixedCaseRange when the number of characters at the start or end of range is other than 1. (@koic)
  • #11992: Fix an unexpected NoMethodError for built-in language server when an internal error occurs. (@koic)
  • #11994: Fix an error for Layout/LineEndStringConcatenationIndentation when inspecting the % from string %\n\n. (@koic)
  • #12007: Fix an error for Layout/SpaceAroundOperators when using unary operator with double colon. (@koic)
  • #11996: Fix an error for Style/IfWithSemicolon when without branch bodies. (@koic)
  • #12009: Fix an error for Style/YodaCondition when equality check method is used without the first argument. (@koic)
  • #11998: Fix an error when inspecting blank heredoc delimiter. (@koic)
  • #11989: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using unicode chars. (@koic)
  • #12001: Fix code length calculator for method calls with heredoc. (@fatkodima)
  • #12002: Fix Lint/Void cop for __ENCODING__ constant. (@fatkodima)

Changes

  • #11983: Add Ridgepole files to default Include list. (@ydah)
  • #11738: Enhances empty_line_between_defs to treat configured macros like defs. (@catwomey)

1.53.1

Bug fixes

  • #11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. (@koic)
  • #11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. (@koic)
  • #11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . (@KessaPassa)

1.53.0

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@rwstauner)

Changes

  • #11904: Mark Layout/ClassStructure as unsafe to autocorrect. (@nevans)
  • #8506: Add AllowedParentClasses config to Lint/MissingSuper. (@iMacTia)

1.52.1

Bug fixes

  • #11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. (@koic)
  • #11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. (@rafaelfranca)
  • #11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. (@koic)
  • #11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. (@koic)
  • #11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. (@lucthev)

Changes

1.52.0

New features

  • #11873: Add ComparisonsThreshold config option to Style/MultipleComparison. (@fatkodima)
  • #11886: Add new Style/RedundantArrayConstructor cop. (@koic)
  • #11873: Add new Style/RedundantRegexpConstructor cop. (@koic)
  • #11841: Add new Style/RedundantFilterChain cop. (@fatkodima)
  • #11908: Support AllowedReceivers for Style/CollectionMethods. (@koic)

Bug fixes

  • #11890: Fix a false negative for Lint/RedundantSafeNavigation when &. is used for to_d. (@koic)
  • #11880: Fix a false positive for Style/ExactRegexpMatch when using literal with quantifier in regexp. (@koic)
  • #11902: Fix a false positive for Style/RequireOrder when single-quoted string and double-quoted string are mixed. (@koic)
  • #11879: Fix a false positive for Style/SelectByRegexp when Ruby 2.2 or lower analysis. (@koic)
  • #11891: Fix Style/AccessorGrouping to accept macros separated from accessors by space. (@fatkodima)
  • #11905: Fix an error for Lint/UselessAssignment when a variable is assigned with rest assignment and unreferenced. (@koic)
  • #11899: Fix an incorrect autocorrect for Style/SingleLineMethods when using Ruby 3.0 and Style/EndlessMethod is disabled. (@koic)
  • #11884: Make rubocop -V display rubocop-factory_bot version when using it. (@koic)
  • #11893: Fix a false positive for Lint/InheritException when inheriting Exception with omitted namespace. (@koic)
  • #11898: Fix offences in calls inside blocks with braces for Style/MethodCallWithArgsParentheses with omit_parentheses enforced style. (@gsamokovarov)
  • #11857: Server mode: only read $stdin when -s or --stdin argument provided. (@naveg)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rexml (indirect, 3.2.5 → 3.2.6) · Repo · Changelog

Release Notes

3.2.6

Improvements

  • Required Ruby 2.5 or later explicitly.
    GH-69
    [Patch by Ivo Anjo]

  • Added documentation for maintenance cycle.
    GH-71
    [Patch by Ivo Anjo]

  • Added tutorial.
    GH-77
    GH-78
    [Patch by Burdette Lamar]

  • Improved performance and memory usage.
    GH-94
    [Patch by fatkodima]

  • REXML::Parsers::XPathParser#abbreviate: Added support for
    function arguments.
    GH-95
    [Reported by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added support for string
    literal that contains double-quote.
    GH-96
    [Patch by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added missing / to
    :descendant_or_self/:self/:parent.
    GH-97
    [Reported by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added support for more patterns.
    GH-97
    [Reported by pulver]

Fixes

  • Fixed a typo in NEWS.
    GH-72
    [Patch by Spencer Goodman]

  • Fixed a typo in NEWS.
    GH-75
    [Patch by Andrew Bromwich]

  • Fixed documents.
    GH-87
    [Patch by Alexander Ilyin]

  • Fixed a bug that Attriute convert ' and ' even when
    attribute_quote: :quote is used.
    GH-92
    [Reported by Edouard Brière]

  • Fixed links in tutorial.
    GH-99
    [Patch by gemmaro]

Thanks

  • Ivo Anjo

  • Spencer Goodman

  • Andrew Bromwich

  • Burdette Lamar

  • Alexander Ilyin

  • Edouard Brière

  • fatkodima

  • pulver

  • gemmaro

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:

🆕 language_server-protocol (added, 3.17.0.3)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 1, 2023
@depfu
Copy link
Contributor Author

depfu bot commented Aug 10, 2023

Closed in favor of #1310.

@depfu depfu bot closed this Aug 10, 2023
@depfu depfu bot deleted the depfu/update/rubocop-1.55.1 branch August 10, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants