Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment for GCP firewall rules #312

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add comment for GCP firewall rules #312

merged 1 commit into from
Jan 29, 2025

Conversation

BillAnastasiadis
Copy link
Collaborator

This pr adds a comment clarifying the logic behind the GCP firewall rules in our deployment.

  • only comments added, so no VR

alvarocarvajald
alvarocarvajald approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpagot
mpagot approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit 98a757b into SUSE:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

@mpagot mpagot mpagot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillAnastasiadis @alvarocarvajald @mpagot