Manage terraform AWS IP address and ranges #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
force-pushed
the
terraform_aws_netaddress
branch
from
3ebecfd to
e22cb2a
Compare
Move all the locals about ip address and ranges to a dedicated file. Change indentation to split long lines. Create intermediate new locals to make algorithm hopefully more readable. Start considering 4 initial IP address that AWS reserve. Calculate each range and IP dinamically using the previous one as starting point.
mpagot
force-pushed
the
terraform_aws_netaddress
branch
from
e22cb2a to
6f5fb4d
Compare
lpalovsky
approved these changes
Feb 7, 2025
| @@ -49,6 +28,9 @@ locals { | |||
| netweaver_os_image = var.netweaver_os_image != "" ? var.netweaver_os_image : var.os_image | |||
| netweaver_os_owner = var.netweaver_os_owner != "" ? var.netweaver_os_owner : var.os_owner | |||
|
|
|||
| netweaver_xscs_server_count = var.netweaver_enabled ? (var.netweaver_ha_enabled ? 2 : 1) : 0 | |||
There was a problem hiding this comment.
isn't it supposed to be ascs instead of xscs ?
There was a problem hiding this comment.
same acronym is used everywhere down to the module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the locals about ip address and ranges to a dedicated file. Change indentation to split long lines.
Create intermediate new locals to make algorithm hopefully more readable. Start considering 4 initial IP address that AWS reserve. Calculate each range and IP dynamically using the previous one as starting point.
Ticket: TEAM-9980
Verification
No peering
sle-15-SP5-HanaSr-Aws-Byos-x86_64-Build15-SP5_2025-02-05T03:03:21Z-hanasr_aws_test_fencing_native ec2_r4.8xlarge
http://openqaworker15.qa.suse.cz/tests/312776 🟢 no any special vpc address range specified in http://openqaworker15.qa.suse.cz/tests/312776/file/deploy_qesap_terraform-sles4sap_aws_generic.yaml and http://openqaworker15.qa.suse.cz/tests/312776/file/deploy_qesap_terraform-terraform.tfvars . The two hana nodes get the default private IP http://openqaworker15.qa.suse.cz/tests/312776/logfile?filename=deploy_qesap_terraform-terraform.apply.log.txt
http://openqaworker15.qa.suse.cz/tests/312976 🟢 deployment is fine
sle-15-SP3-HanaSr-Aws-Byos-x86_64-Build15-SP3_2025-02-05T03:03:21Z-hanasr_aws_test_fencing_native ec2_r4.8xlarge
sle-15-SP6-HanaSr-Aws-Payg-x86_64-Build15-SP6_2025-02-05T03:03:21Z-hanasr_aws_test_fencing_native_stop_kill ec2_r4.8xlarge
Peering
sle-15-SP5-Qesap-Aws-Payg-x86_64-BuildLATEST_AWS_SLE15_5_PAYG-qesap_aws_saptune_test
vpc_address_range: '10.11.120.0/21'in the conf.yaml file. It result in http://openqaworker15.qa.suse.cz/tests/312975/logfile?filename=deploy-terraform.apply.log.txt