Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longer cache byos #1106

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Longer cache byos #1106

merged 2 commits into from
Mar 6, 2024

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Mar 6, 2024

Description

Given the high number of re requests to SCC for BYOS systems to refresh the cache, extend the cache longer for BYOS systems

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

@jesusbv jesusbv requested review from digitaltom and rjschwei March 6, 2024 13:08
@jesusbv jesusbv self-assigned this Mar 6, 2024
@jesusbv jesusbv force-pushed the longer-cache-byos branch from 59ac545 to 5784a75 Compare March 6, 2024 13:21
@jesusbv
Add longer expiration date for BYOS systems
6a08c91 
- Update tests
- Rubocop compliant
- Update changelog to keep track of public cloud changes
@jesusbv jesusbv force-pushed the longer-cache-byos branch from 935872c to 6a08c91 Compare March 6, 2024 14:50
@digitaltom digitaltom merged commit 73081ef into master Mar 6, 2024
3 checks passed
@digitaltom digitaltom deleted the longer-cache-byos branch March 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitaltom digitaltom digitaltom approved these changes

@rjschwei rjschwei Awaiting requested review from rjschwei

Assignees

@jesusbv jesusbv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusbv @digitaltom