Configure SUMA product tree base URL

[lcaparroz]

Description

Allow user to configure the SUMA product tree base URL in RMT's config file mirroring.suma_product_tree_base_url attribute. The configured value takes precedence over the default (https://scc.suse.com/suma/).

• Related Issue / Ticket / Trello card: https://trello.com/c/Fv5zbDoj/3694-rgs-configure-suma-product-tree-base-url-in-rmt

How to test

On your local setup, change the attribute mirroring.suma_product_tree_base_url on config/rmt.local.yml to point to a custom URL (the URL must be reachable and respond to <custom URL>/product_tree.json, e.g.:

mirroring:
  mirror_src: false
  verify_rpm_checksums: false
  dedup_method: hardlink
  suma_product_tree_base_url: <custom URL>/suma/

Then, run bin/rmt-cli mirror, and verify that the log output shows that the mirroring process has finished without any errors regarding the SUMA product tree.

Change Type

Please select the correct option.

• Bug Fix (a non-breaking change which fixes an issue)
• New Feature (a non-breaking change which adds new functionality)
• Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

• I have reviewed my own code and believe that it's ready for an external review.
• I have provided comments for any hard-to-understand code.
• I have documented the MANUAL.md file with any changes to the user experience.
• If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

[digitaltom]

@lcaparroz @Adnilson My comment was resolved here without proper discussion I think.
What I was asking is: Why do we need an additional config value for the SUMA_PRODUCT_TREE_BASE_URL, when we already have SCC_HOST? I think the problem we want to solve here is, the hardcoded FILE_URL in lib/rmt/mirror/suma_product_tree.rb not using SCC_HOST (see also https://bugzilla.suse.com/show_bug.cgi?id=1234844).
What's the use case of configuring an extra host in SUMA_PRODUCT_TREE_BASE_URL?