Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter by the whole key #1280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

filter by the whole key #1280

wants to merge 1 commit into from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Jan 31, 2025

Description

When creating or updating a system during regsharing, use the full unique combination

This Fixes bsc#1236600

How to test

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

When creating or updating a system during regsharing,
use the full unique combination

This Fixes bsc#1236600
@jesusbv jesusbv self-assigned this Jan 31, 2025
Copy link
Member

@digitaltom digitaltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. But this needs testing, because I could imagine that when the system token rotates on the source RMT, the system would not get found on the target RMT anymore because it has a different system token. How do we handle that case?

@jesusbv jesusbv added the 2.22 label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants