-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery refactored master branch #1
base: master
Are you sure you want to change the base?
Conversation
for word in keywords.keys(): | ||
score = keywords[word] | ||
for word, score in keywords.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function calc_score
refactored with the following changes:
- Use items() to directly unpack dictionary values (
use-dict-items
) - Remove unnecessary call to keys() (
remove-dict-keys
)
sleep_time = 1 | ||
|
||
# urlencode | ||
from_text = urllib.parse.quote(from_text) | ||
|
||
# url作成 | ||
url = 'https://www.deepl.com/translator#' \ | ||
+ from_lang + '/' + to_lang + '/' + from_text | ||
url = f'https://www.deepl.com/translator#{from_lang}/{to_lang}/{from_text}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_translated_text
refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block
) - Replace unused for index with underscore (
for-index-underscore
) - Use f-string instead of string concatenation [×5] (
use-fstring-for-concatenation
)
day_before_yesterday = datetime.datetime.today() - datetime.timedelta(days=2) | ||
day_before_yesterday = datetime.datetime.now() - datetime.timedelta(days=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function main
refactored with the following changes:
- Replace datetime.datetime.today() with datetime.datetime.now() (
use-datetime-now-not-today
)
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run:Help us improve this pull request!