[마이페이지,시작페이지] 최종 QA 반영입니다 ! #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 2, 2024 20:17
|
hoeun0723
added
refactor ⚙️
imeureka
approved these changes
Mar 10, 2024
urjimyu
approved these changes
Mar 10, 2024
| @@ -3,6 +3,7 @@ import styled from 'styled-components'; | |||
| export const DetailDoneRoomWrapper = styled.div` | |||
| ${({ theme: { mixin } }) => mixin.flexCenter({})}; | |||
| width: 100%; | |||
| height: 100vh; | |||
There was a problem hiding this comment.
오오...!! 스크롤 안되던 문제를 100vh를 줘서 해결하신걸까요??
There was a problem hiding this comment.
앗 중앙정렬을 위해 100vh를 적용해주었습니다 !
ExceptAnyone
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
📸 스크린샷
bandicam.2024-03-10.16-17-32-251.mp4
Reference