Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[시작페이지] 토너먼트 이미지 삭제 후 webp 변환 #494

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[시작페이지] 토너먼트 이미지 삭제 후 webp 변환 #494

merged 1 commit into from
Mar 13, 2024

Conversation

hoeun0723
Copy link
Contributor

이슈 넘버

구현 사항

  • 토너먼트 lottie 지우고, 이미지 png 다운 받아서 webp로 적용

Need Review

  • 토너먼트 lottie animation 이슈가 있어서, 폰에 따라서 보이는 경우가 있고 안 보이는 경우가 있더라구요!! 그래서 일단 스프린트를 위해 png로 전체 화면 뽑아서 webP 로 변환하여 올려뒀어요 !!!! 지금 2차 스프린트에는 이미지로 놔두는게 좋을 거 같아요 !!

📸 스크린샷

Reference

@hoeun0723 hoeun0723 added fix 🛠️ Something isn't working 시작페이지 📄 스윗 맨 처음 진입 화면 페이지 labels Mar 13, 2024
@hoeun0723 hoeun0723 self-assigned this Mar 13, 2024
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.6
🚀 Deployed preview to https://SWEET-DEVELOPERS.github.io/sweet-client/pr-preview/pr-494/
on branch gh-pages at 2024-03-13 06:04 UTC

@hoeun0723 hoeun0723 merged commit e918801 into develop Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urjimyu urjimyu urjimyu approved these changes

@imeureka imeureka imeureka approved these changes

@ExceptAnyone ExceptAnyone ExceptAnyone approved these changes

Assignees

@hoeun0723 hoeun0723

Labels
fix 🛠️ Something isn't working 시작페이지 📄 스윗 맨 처음 진입 화면 페이지
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoeun0723 @urjimyu @imeureka @ExceptAnyone