[feat] #122 tournament 종료 API 구현 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🍫
Summary 🍪
Before i request PR review 🍰
토너먼트 종료 시간에 대한 필드 추가도 고민해봤는데 다른 api에서 토너먼트 종료시간 계산을 TournamentStartDate랑 duration으로해서 꼬일 거 같아서 TournamentStartDate(토너먼트 시작 시간)을 조정하는 방향으로 구현했습니다. (TournamentStartDate = 현재시간 - duration)