Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add PushToken entity #164

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Chaerim1001
Copy link
Member

Related Issue

none

Description

pushToken Entity를 추가하였습니다.

@Chaerim1001 Chaerim1001 added the ✨ feat 기능 추가와 관련된 작업을 명시합니다. label Nov 8, 2023
@Chaerim1001 Chaerim1001 requested a review from KAispread November 8, 2023 08:40
@Chaerim1001 Chaerim1001 self-assigned this Nov 8, 2023
Copy link
Member

@KAispread KAispread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인 부탁드립니다..! 그리고 Sonar qube도 확인 부탁드려요


private void setMember(final Member member) {
this.member = member;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Override
public boolean isNew() {
    return createdAt == null;
}

AUTO_INCREMENT 가 아닐 경우에 데이터 삽입시 IsNew를 재정의하지 않으면, ID 값이 중복되는지 확인하기 위해서 SELECT 쿼리가 발생합니다..!
IsNew 재정의 코드 삽입 부탁드립니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다!

Copy link

sonarqubecloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Chaerim1001 Chaerim1001 merged commit de72cff into develop Nov 8, 2023
2 of 3 checks passed
@Chaerim1001 Chaerim1001 deleted the E2I-none-rim/add-push-token-entity branch November 8, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 추가와 관련된 작업을 명시합니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants