Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Settings Loader Issues: Resolve KeyErrors, Path Handling, and Component Assignment (#731) #741

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

Chiyan200
Copy link
Contributor

Robust settings loader to handle missing keys, incorrect file paths, and dynamic assignment

  • Ensured default settings are properly merged with file-based settings to prevent KeyErrors.
  • Added logic to handle _pinyin and _char suffixes in project names, ensuring correct file paths.
  • Implemented tuple-based ordered mapping for consistent and error-free component assignment.
  • Added safety check to verify the existence of setting.json before loading.
  • Improved maintainability by centralizing default settings and enhancing error handling.

error-ezgif com-video-to-gif-converter
Bug Fixed!

…ths, and dynamic assignment

- Ensured default settings are properly merged with file-based settings to prevent KeyErrors.
- Added logic to handle _pinyin and _char suffixes in project names, ensuring correct file paths.
- Implemented tuple-based ordered mapping for consistent and error-free component assignment.
- Added safety check to verify the existence of setting.json before loading.
- Improved maintainability by centralizing default settings and enhancing error handling.
@SWivid SWivid merged commit 46266f1 into SWivid:main Jan 27, 2025
1 check passed
@SWivid
Copy link
Owner

SWivid commented Jan 27, 2025

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants