Adding support for detached headers for crypto root #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
reviewed
Jan 27, 2018
| @@ -222,8 +296,8 @@ _open_luks() { | |||
| # At this point, keyfile or not, we're ready! | |||
| local ply_cmd="${gpg_ply_cmd}${CRYPTSETUP_BIN}" | |||
| local tty_cmd="${gpg_tty_cmd}${CRYPTSETUP_BIN}" | |||
| ply_cmd="${ply_cmd} ${cryptsetup_opts} luksOpen ${luks_device} ${luks_dev_name}" | |||
| tty_cmd="${tty_cmd} ${cryptsetup_opts} luksOpen ${luks_device} ${luks_dev_name}" | |||
| ply_cmd="${ply_cmd} ${cryptsetup_opts} luksOpen ${luks_device} ${luks_dev_name}${header_opts}" | |||
There was a problem hiding this comment.
minor note: afaics there isn't a default value for header_opts (that would be empty one anyway).
Overall looks good to me
|
Hi, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically copied the code for the key and adapted it bit to do the headers.
Working fine on my gentoo box.
Looking something like this then in default/grub
GRUB_CMDLINE_LINUX="crypt_roots=/dev/disk/by-id/ata-Samsung_SSD_850_EVO_250GB_S2R6NX0J363411N-part1 root_header=/luks-header root_headerdev=UUID=cadca53c-3a05-4ed2-84fe-f2d1d03e812e root_trim=yes dolvm quiet spalsh"
If used it will need more testing as I only have my one box where I'm running it.
Feel free to use or discard as you feel.
If you have, feedback would be appreciated