Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding of source files unclear #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yankee42
Copy link

In InvokeDynamicCP.java:28 and in MethodHandleCP.java:27 there are ISO-8559-15 characters (the € sign).

This causes warnings when I do a build on my (Linux) machine (default charset is UTF-8 here):

    [javac] /tmp/sableJasmin/jasmin/lib/jas/src/jas/InvokeDynamicCP.java:28: warning: unmappable character for encoding UTF8
    [javac]     uniq = (bsmClassName + "fv0�" + bsmName + "&%$91&" + bsmSig+ "*(012$" + methodName + "dfg8932" + methodSig).intern();
    [javac]                                ^
    [javac] /tmp/sableJasmin/jasmin/lib/jas/src/jas/MethodHandleCP.java:27: warning: unmappable character for encoding UTF8
    [javac]     uniq = kind + "$gfd�" + ownerName + "&%$91&" + fieldOrMethodName + "*(012$" + sig;
    [javac]                        ^

I suppose this is not on purpose. To solve this one of the following could be done:

  1. Replace the euro sign with an escape sequence (\u20ac)
  2. Specify encoding="ISO-8559-15" in the ANT-javac-Task

I'd be glad to create a pull request if you tell me which of the two it is supposed to be.

@ericbodden
Copy link
Member

Hi and thanks! I think going with \u20ac would be easier. Could you please add a comment to the code, too? Thanks in advance!

…equence \u20ac to ensure a stable build across platforms without specifying the file encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants