Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-4243: fix region lookup #21

Merged
merged 6 commits into from
Jan 30, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
IT-4243: improvement from review
Hallie Swan committed Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 3e84369e7122a1af33ae7839f024d6e579e78711
1 change: 0 additions & 1 deletion .github/workflows/aws-deploy.yaml
Original file line number Diff line number Diff line change
@@ -51,4 +51,3 @@ jobs:
run: cdk deploy --all --concurrency 5 --require-approval never
env:
ENV: ${{ inputs.environment }}
REGION: ${{ inputs.aws-region }}
6 changes: 1 addition & 5 deletions app.py
Original file line number Diff line number Diff line change
@@ -13,14 +13,10 @@
from src.bastion_props import BastionProps
from src.bastion_stack import BastionStack

# get the region, or use a default
region = environ.get("REGION")
if region is None:
region = "us-east-1"

# get the environment and set environment specific variables
VALID_ENVIRONMENTS = ["dev", "stage", "prod"]
environment = environ.get("ENV")
region = environ.get("AWS_REGION")
match environment:
case "prod":
environment_variables = {