Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLFM-8102: Use Admin Access #1254

Merged
merged 8 commits into from
Dec 5, 2024
Merged

PLFM-8102: Use Admin Access #1254

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d77f80
Use cdk role
xschildw Oct 11, 2024
e9e7bf8
Merge branch 'master' into m-plfm-8102-use-cdk-bootstrap-role
xschildw Nov 7, 2024
cd44614
Park
xschildw Nov 7, 2024
e19a8ce
Merge branch 'master' into m-plfm-8102-use-cdk-bootstrap-role
xschildw Nov 11, 2024
f16de2c
Use inline policy to allow assuming cdk* roles
xschildw Nov 11, 2024
ba09cd6
Merge branch 'master' into m-plfm-8102-use-cdk-bootstrap-role
xschildw Nov 25, 2024
befc4c3
use admin access
xschildw Nov 25, 2024
8e17691
combine synapse-related oidc
xschildw Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 24 additions & 26 deletions org-formation/650-identity-providers/_tasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,30 @@ GithubOidcSageBionetworksSynapseDockerRegistry:
- !Ref SynapseProdAccount
Region: us-east-1

GithubOidcSageBionetworksSynapse:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to also replace the role used by GH actions in synapse-docker-registry repo with the one generated from this new GithubOidcSageBionetworksSynapse resource? And then of course also remove GithubOidcSageBionetworksSynapseDockerRegistry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Type: update-stacks
DependsOn: GithubOidcSageBionetworks
Template: https://raw.githubusercontent.com/Sage-Bionetworks/aws-infra/v0.7.6/templates/IAM/github-oidc-provider.j2
StackName: !Sub ${resourcePrefix}-${appName}-sage-bionetworks-synapse
Parameters:
ProviderArn: !CopyValue [ !Sub '${resourcePrefix}-${appName}-ProviderArn' ]
ProviderRoleName: !Sub ${resourcePrefix}-${appName}-sage-bionetworks-synapse
ManagedPolicyArns:
- "arn:aws:iam::aws:policy/AdministratorAccess"
- "arn:aws:iam::aws:policy/AWSKeyManagementServicePowerUser"
TemplatingContext:
GitHubOrg: "Sage-Bionetworks"
Repositories:
- name: "synapse-docker-registry"
branches: ["*"]
- name: "nbconvert-webapp"
branches: ["master", "develop"]
DefaultOrganizationBinding:
Account:
- !Ref SynapseDevAccount
- !Ref SynapseProdAccount
Region: us-east-1

GithubOidcSageBionetworksGenieBPCInfra:
Type: update-stacks
DependsOn: GithubOidcSageBionetworks
Expand Down Expand Up @@ -872,32 +896,6 @@ GithubOidcOpenChallengesDeploy:
- !Ref OpenChallengesProdAccount
Region: us-east-1

GithubOidcNbConvertDeploy:
Type: update-stacks
DependsOn: GithubOidcSageBionetworks
Template: https://raw.githubusercontent.com/Sage-Bionetworks/aws-infra/v0.7.6/templates/IAM/github-oidc-provider.j2
StackName: !Sub ${resourcePrefix}-${appName}-nbconvert-deploy
Parameters:
ProviderArn: !CopyValue [ !Sub '${resourcePrefix}-${appName}-ProviderArn' ]
ProviderRoleName: !Sub ${resourcePrefix}-${appName}-nbconvert-deploy
MaxSessionDuration: 7200
ManagedPolicyArns:
- "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryFullAccess"
- "arn:aws:iam::aws:policy/AWSLambda_FullAccess"
- "arn:aws:iam::aws:policy/CloudWatchLogsFullAccess"
- "arn:aws:iam::aws:policy/IAMFullAccess"
- "arn:aws:iam::aws:policy/AWSCloudFormationFullAccess"
TemplatingContext:
GitHubOrg: "Sage-Bionetworks"
Repositories:
- name: "nbconvert-webapp"
branches: ["master", "develop"]
DefaultOrganizationBinding:
Account:
- !Ref SynapseDevAccount
- !Ref SynapseProdAccount
Region: us-east-1

############################### Managed Policies ###############################
# Managed policies used in github OIDC providers
# Note: Managed policies can be used as work around for the AWS cloudformation
Expand Down
Loading