Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-3931] Create a hosted zone for dpe.org #1268

Closed
wants to merge 1 commit into from

Conversation

zaro0508
Copy link
Contributor

We have aquired the sagedpe.org domain in the org-sagebase-sageit account. Now we need to create a hosted zone for that domain.

We have aquired the `sagedpe.org` domain in the org-sagebase-sageit
account. Now we need to create a hosted zone for that domain.
@zaro0508 zaro0508 requested a review from a team as a code owner October 25, 2024 19:07
@zaro0508 zaro0508 requested a review from BryanFauble October 25, 2024 19:14
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

StackDescription: Create a shared hosted zone for application in dpe.org
DefaultOrganizationBindingRegion: !Ref primaryRegion
DefaultOrganizationBinding:
Account: !Ref SageITAccount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the subdomain not be created in the account where the assets are going to be deployed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we requested the sagedpe.org in the org-sagebase-sageit account then i think we need a hosted zone for it in the same account as well. The hosted zone will allow us to verify TLS certificate ownership (via DNS verification) and setup redirect to apps running in other accounts. That seems like the pattern that has been establish to me or am I missing something @xschildw ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay...
The domain 'sagedpe.org' has an associated hosted zone. I think it would work as-is (including certificate validation for subdomains), with the caveat that you'll need cross-account access if you want to create from another account (where your resources live), or use a separate script running in sageit to create the records.
This PR creates a new zone 'dpe.sagedpe.org', that would work to create records for that domain and its subdomains. NS records would need to be created in 'sagedpe.org' to delegate DNS to this zone for the 'dpe' subdomain. The zone can be created in any account (typically we put it where the resources that need DNS records are created, so your DNS is colocated with your resources). I think same account is required if you use alias records. Another advantage is that it's cleaner if you have a lot of subdomains/records.
If 'dpe.sagedpe.org' is just an endpoint maybe we don't need an extra zone at all, if there are several resources/records in 'dpe.sagedpe.org' I'd create a zone in the account where the resources are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, i think AWS automatically creates a hosted zone upon a successful request of a new domain (sagedpe.org). Darn, sorry I didn't notice that the hosted zone was created. Thanks @xschildw.

@zaro0508 zaro0508 requested a review from xschildw November 4, 2024 15:20
@zaro0508
Copy link
Contributor Author

zaro0508 commented Nov 4, 2024

hosted zone already setup, no need to create another one.

@zaro0508 zaro0508 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants