Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-3988: Add permission to create object in S3 #1273

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

xschildw
Copy link
Contributor

@xschildw xschildw commented Nov 5, 2024

This PR adds a in-line policy to LLMDeveloper role that gives the permission to create objects in S3 (upload templates).

@xschildw xschildw requested a review from a team as a code owner November 5, 2024 20:38
@xschildw xschildw requested a review from zaro0508 November 5, 2024 20:39
Copy link
Contributor

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but I wonder if you also need permission to read and delete objects.

@xschildw
Copy link
Contributor Author

xschildw commented Nov 6, 2024

Good point, the error was specifically to upload the file so hoping it'll be enough... Let's try!

@xschildw xschildw merged commit 41c4c58 into Sage-Bionetworks-IT:master Nov 6, 2024
3 checks passed
@xschildw xschildw deleted the m-it-3988 branch November 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants