Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextflow schema #14

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Add Nextflow schema #14

merged 7 commits into from
Aug 24, 2023

Conversation

adamjtaylor
Copy link
Collaborator

Thank you @rxu17 for starting this! I have refined it slightly and think it is now in a place for us to merge.

@adamjtaylor
Copy link
Collaborator Author

Here is what the schema looks like in tower:
Screenshot 2023-08-18 at 10 54 56

Copy link

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question

"remove_bg": {
"type": "boolean",
"description": "Remove non-tissue background",
"default": true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we ever want to have the option to not remove background? (false)

Copy link
Collaborator Author

@adamjtaylor adamjtaylor Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when set to false the background is kept. Default is true as we expect this to be the case the majority of the time

@adamjtaylor adamjtaylor merged commit edde6a5 into main Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants