Fix samplesheet location for test profile #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving back to draft while I figure out why this is not working. |
|
I had tried to mimic this line from sarek's test.conf |
|
nf-core/rnaseq uses a raw github link: https://github.com/nf-core/rnaseq/blob/3bec2331cac2b5ff88a1dc71a21fab6529b57a0f/conf/test.config#L24 nf-core/metapep does as well |
|
Decided to point to the raw github url of the samplesheet as this seems more common for nf-core workflows |
|
Looks like we need the test data defined by URL as well |
thomasyu888
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test profile fails if run from outside the project directory.
This explicitly PR declares in the test config that the test samplesheet is
nested under the projectDirlocated at a public raw github url