Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ome_types version #26

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update ome_types version #26

merged 1 commit into from
Oct 11, 2023

Conversation

adamjtaylor
Copy link
Collaborator

The latest ome_types release v0.4.2 contains a fix for a bug in pydantic-extra-types.

https://github.com/tlambert03/ome-types/releases/tag/v0.4.2

We should update the Dockerfile to specify the latest version.

@adamjtaylor adamjtaylor self-assigned this Oct 11, 2023
@adamjtaylor adamjtaylor added the bug Something isn't working label Oct 11, 2023
@adamjtaylor adamjtaylor merged commit f09df3c into main Oct 11, 2023
4 checks passed
@adamjtaylor adamjtaylor deleted the update-ome-types branch October 11, 2023 15:50
@adamjtaylor
Copy link
Collaborator Author

adamjtaylor commented Oct 11, 2023

The CI action failed with the error

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

I have restarted the run and will report back.

It looks like this could have been a docker runner timeout as the logs stop at

#11 181.0 Solving environment: ...working...

@adamjtaylor
Copy link
Collaborator Author

adamjtaylor commented Oct 11, 2023

@thomasyu888 this timed out again.

docker
The hosted runner encountered an error while running your job. (Error Type: Disconnect).
docker
Received request to deprovision: The request was cancelled by the remote provider.

I'll look at it tomorrow in building the container locally (likely a version clash with other requirements in the conda env). If I can solve or speed up I will make the fix, if not I will revert this PR.

@adamjtaylor
Copy link
Collaborator Author

This issue suggests the error is due to Github terminating the runner on high memory or CPU usage.
actions/runner-images#7897

@adamjtaylor
Copy link
Collaborator Author

We should also look for the action to build (but not submit) the image in the PR before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants