-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify output directory structure #7
Conversation
We should make sure that different tower executions will write to different buckets so you're not overwriting anything. That said, I agree with this simplification. |
Is there a best-practice way to do this? Or OK to leave to good user practice to change the outdir for each run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few comments/questions.
Should we also have a README that just briefly describes the output directory structure here?
Also, is there a release versioning system that nf-artist runs under so we can version by that as a top-level folder for the outputs since we are removing the nextflow workflow name? It could be a parameter we enter (or it can be attached to a repo tag?).
@rxu17, @thomasyu888 looking at nf-core for best-practice guidance, I don't see anything about adding any automated versioning or id- or run-name based structure into the output directory. I think we are therefore good to continue with the simplified approach in this PR and leave it up to the user to be aware of their output versioning etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Our current output structure is as follows
The intention of the two occurrences of run name were
I'm proposing this is simplified by removing both of these nested run names.
Story.json will also be moved under the minerva directory
The new structure would be