Use id column from samplesheet if specified #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
approved these changes
Aug 17, 2023
| @@ -9,7 +9,12 @@ workflow SAMPLESHEET_SPLIT { | |||
| .map { | |||
| row -> | |||
| def meta = [:] | |||
| meta.id = file(row.image).simpleName | |||
| if (row.id ) { | |||
| meta.id = row.id | |||
There was a problem hiding this comment.
For HTAN we would use a Synapse ID, but this could be used any time you don't want the output directories to be named by the filename and want to provide a custom ID in their place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For HTAN we stage the outputs from nf-artist using the original synapse ID of the file as part of the URL, for example:
https://d3p249wtgzkn5u.cloudfront.net/synid/syn25075713/stoic_franklin/thumbnail.png
To allow for nf-artist to by not dependent on Synapse the current samplesheet takes a column
imagethat is the path to a staged image.It would be advantageous for HTAN and other projects to allow for a
idcolumn in the samplesheet that gets taken into the meta map asidif specified, if not specified the current behavior of using the imagesimpleNameis used.