[IBCDPE-691] Adds Ability to Retrieve Workflow Task Logs from Tower #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story IBCDPE-691 · Extract hundreds of tower execution logs easily |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 874 920 +46
Branches 138 140 +2
=========================================
+ Hits 874 920 +46
☔ View full report in Codecov by Sentry. |
BWMac
commented
Oct 25, 2023
BWMac
commented
Oct 25, 2023
BWMac
commented
Oct 25, 2023
BryanFauble
reviewed
Oct 25, 2023
BryanFauble
reviewed
Oct 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the
nextflowtowerservice to retrieve metadata for the individual tasks in a Tower workflow run, and then to retrieve the execution logs for those individual tasks.To do this, I implemented the
get_workflow_tasksmethods inNextflowTowerClientandNextflowTowerOps.client.get_workflow_tasksuses the/workflow/{workflow_id}/tasksTower API endpoint to retrieve information about all of the tasks. Each individual task dictionary is then converted into amodels.WorkflowTaskobject.Task logs can now be retrieved by using the
get_task_logsmethods inclientandops.client.get_task_logsuses the/workflow/{workflow_id}/log/{task_id}Tower API endpoint to retrieve execution logs for an individual task.Tests and example responses have also been added where necessary for all new methods.
Finally, I have included
demo_nf_logs.pyas an example of a Metaflow DAG that users can follow to retrieve task logs and evaluate why a workflow task has failed. I am unsure whether this script should belong in this repo, or inorca-recipes, however.