Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-749] Clarify points in documentation #36

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Jan 12, 2024

problem

docs could use a few points of clarification.

solution

update the README.md and .env.example accordingly.

testing & preview

N/A

@jaymedina jaymedina self-assigned this Jan 12, 2024
Copy link

swarmia bot commented Jan 12, 2024

✅  Linked to Story IBCDPE-749 · Onboard onto ORCA
➡️  Part of Epic IBCDPE-739 · DPE Onboarding - Jenny Medina

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04a94ee) 100.00% compared to head (1b0ce17) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          920       920           
  Branches       140       140           
=========================================
  Hits           920       920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jaymedina jaymedina marked this pull request as ready for review January 12, 2024 17:17
@jaymedina jaymedina requested a review from a team as a code owner January 12, 2024 17:17
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this extra content. Changes LGTM!

@jaymedina
Copy link
Contributor Author

Thanks @BryanFauble , will do a merge after final test passes.

@jaymedina jaymedina merged commit 433e7ae into main Jan 12, 2024
11 checks passed
@jaymedina jaymedina deleted the IBCDPE-749-doc-updates branch January 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants